Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitwarden: 2023.9.3 -> 2023.10.0 #264945

Merged
merged 2 commits into from
Nov 5, 2023
Merged

bitwarden: 2023.9.3 -> 2023.10.0 #264945

merged 2 commits into from
Nov 5, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Kiwi November 2, 2023 06:40
amarshall
amarshall approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build and basic functionality on x86_64-linux

@dotlambda dotlambda merged commit 96fb727 into NixOS:master Nov 5, 2023
27 of 28 checks passed
@dotlambda dotlambda deleted the bitwarden-2023.10.0 branch November 5, 2023 17:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-264945-to-release-23.05 origin/release-23.05
cd .worktree/backport-264945-to-release-23.05
git checkout -b backport-264945-to-release-23.05
ancref=$(git merge-base 686a5fca36d6ebc0e2fda1c4fac1717e318c4de5 a6253a52cd23e87893a423e554d92e41aba1ae1e)
git cherry-pick -x $ancref..a6253a52cd23e87893a423e554d92e41aba1ae1e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarshall amarshall amarshall approved these changes

@Kiwi Kiwi Awaiting requested review from Kiwi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotlambda @amarshall @delroth