Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyqt6-webengine: remove qtwebengine from nativeBuildInputs #264962

Closed
wants to merge 1 commit into from
Closed

pyqt6-webengine: remove qtwebengine from nativeBuildInputs #264962

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2023

Description of changes

The buildPlatform qtwebengine is not needed. Since qtwebengine also appears in buildInputs the hostPlatform qtwebengine will be depended upon correctly.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The buildPlatform qtwebengine is not needed.  Since qtwebengine also
appears in buildInputs the hostPlatform qtwebengine will be depended
upon correctly.
@ghost ghost marked this pull request as ready for review November 2, 2023 07:24
@ghost ghost requested a review from Artturin November 2, 2023 07:24
@ghost
Copy link
Author

ghost commented Nov 2, 2023

@ofborg build python3Packages.pyqt6-webengine

@LunNova
Copy link
Member

LunNova commented Nov 2, 2023

Result of nixpkgs-review pr 264962 run on x86_64-linux 1

18 packages failed to build:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • calibre
  • mnemosyne
  • mnemosyne.dist
  • python310Packages.pyqt6-webengine
  • python310Packages.pyqt6-webengine.dev
  • python310Packages.pyqt6-webengine.dist
  • python311Packages.pyqt6-webengine
  • python311Packages.pyqt6-webengine.dev
  • python311Packages.pyqt6-webengine.dist
  • qutebrowser
  • qutebrowser.dist
  • retext
  • retext.dist
  • unbook

@ghost ghost marked this pull request as draft November 3, 2023 02:06
@ghost ghost mentioned this pull request Nov 5, 2023
13 tasks
@ghost ghost closed this Jan 23, 2024
@ghost ghost deleted the qt6-qtwebengine-unnecessary-dep branch January 23, 2024 06:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant