Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/matrix-sliding-sync: add dependency on matrix-synapse if running locally #265071

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

999eagle
Copy link
Contributor

@999eagle 999eagle commented Nov 2, 2023

Description of changes

This makes sure matrix-sliding-sync has a dependency on matrix-synapse if both are configured on the same host and configures matrix-sliding-sync to automatically restart as the service fails if synapse is not reachable yet.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This is useful to configure services dependent on matrix-synapse regardless
of whether workers are enabled or not.
@999eagle 999eagle force-pushed the feat/matrix-sliding-sync-update branch from a879fb2 to 8627e0e Compare November 5, 2023 20:44
@Ma27 Ma27 merged commit 19bbcba into NixOS:master Nov 5, 2023
19 checks passed
@Ma27
Copy link
Member

Ma27 commented Nov 5, 2023

Thanks!

@999eagle 999eagle deleted the feat/matrix-sliding-sync-update branch November 6, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants