Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode, vscode-server: 1.83.1 -> 1.84.0 #265487

Merged
merged 1 commit into from
Nov 5, 2023
Merged

vscode, vscode-server: 1.83.1 -> 1.84.0 #265487

merged 1 commit into from
Nov 5, 2023

Conversation

K900
Copy link
Contributor

@K900 K900 commented Nov 4, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@miangraham
Copy link
Contributor

Result of nixpkgs-review pr 265487 run on aarch64-darwin 1

1 package marked as broken and skipped:
  • vscode-fhs
2 packages built:
  • vscode
  • vscode-with-extensions

@Enzime Enzime mentioned this pull request Nov 5, 2023
10 tasks
Copy link
Contributor

@iFreilicht iFreilicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on aarch64-darwin, got the same results with nixpkgs-review, ran code directly from the store and all extensions are loading correctly and work as expected, same for my user's and workspace's configuration.json files.

@K900 K900 merged commit bdba0e9 into NixOS:master Nov 5, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants