Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyqtwebengine: use python.pythonOnBuildForHost #265570

Merged
merged 2 commits into from Nov 6, 2023
Merged

pyqtwebengine: use python.pythonOnBuildForHost #265570

merged 2 commits into from Nov 6, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 5, 2023

Description of changes

When cross compiling, this commit causes pyqtwebengine to use
pythonOnBuildForHost rather than buildPackages.python3Packages,
so it will do the right thing when used with a non-default python
version.

As requested: #264965 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Nov 5, 2023
13 tasks
@ghost ghost marked this pull request as ready for review November 5, 2023 04:32
@ghost ghost requested a review from FRidh as a code owner November 5, 2023 04:32
@ghost ghost mentioned this pull request Nov 6, 2023
13 tasks
@Artturin Artturin merged commit 4f649d6 into NixOS:master Nov 6, 2023
19 checks passed
@ghost ghost deleted the pyqtwebengine-take-different-python3 branch November 6, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant