Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.zxing-cpp: rename from zxing_cpp #265575

Merged
merged 2 commits into from
Nov 6, 2023
Merged

python311Packages.zxing-cpp: rename from zxing_cpp #265575

merged 2 commits into from
Nov 6, 2023

Conversation

natsukium
Copy link
Member

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 265575 at 60404c1 run on x86_64-linux 1

4 packages built successfully:
  • paperless-ngx
  • python310Packages.zxing-cpp
  • python311Packages.zxing-cpp
  • yubioath-flutter

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Nov 5, 2023
@natsukium natsukium mentioned this pull request Nov 5, 2023
Closed
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 5, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 5, 2023
@natsukium natsukium merged commit eecc845 into NixOS:master Nov 6, 2023
28 of 29 checks passed
@natsukium natsukium deleted the zxing-cpp branch November 6, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@lukegb lukegb lukegb approved these changes

@erikarvstedt erikarvstedt Awaiting requested review from erikarvstedt

@leona-ya leona-ya Awaiting requested review from leona-ya

@gador gador Awaiting requested review from gador

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natsukium @lukegb @AndersonTorres @delroth