haskellPackages: work around sdl2 pkg-config issues #265678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is verified using testers.hasPkgConfigModules which leads to a slight refactor of the expression.
This is verified using testers.hasPkgConfigModules which leads to a slight refactor of the expression.
This is verified using testers.hasPkgConfigModules which leads to a slight refactor of the expression.
This is verified using testers.hasPkgConfigModules which leads to a slight refactor of the expression.
sternenseemann
requested review from
cdepillabout and
maralorn
as code owners
This was referenced Nov 5, 2023
ofborg
bot
added
8.has: package (new)
|
Thanks, this LGTM! I manually fixed the merge conflict and merged this is as f10a9c9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)