Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkpasswd: fix build with clang #265824

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

elohmeier
Copy link
Contributor

Description of changes

Fixes the mkpasswd build on darwin based on #260791.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@giomf
Copy link
Contributor

giomf commented Nov 6, 2023

Result of nixpkgs-review pr 265824 run on x86_64-linux 1

4 packages built:
  • automysqlbackup
  • mailutils
  • mailutils.debug
  • mkpasswd

@wegank wegank merged commit cd562b3 into NixOS:master Nov 6, 2023
22 of 24 checks passed
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-265824-to-release-23.11 origin/release-23.11
cd .worktree/backport-265824-to-release-23.11
git switch --create backport-265824-to-release-23.11
git cherry-pick -x 307ef68a01a6c2cc6ab932ef765a2909743130a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants