cosmic-design-demo: init at unstable-2024-01-08

[nyabinary]

Description of changes

Design Demo for COSMIC DE

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[nbdd0121]

I got this error when building:

error: The `!include` directive has been stabilized as `import`

The error is added in Just 1.18 (released 2023-12-24).

[nyabinary]

I got this error when building:

error: The `!include` directive has been stabilized as `import`

The error is added in Just 1.18 (released 2023-12-24).

I believe this is an error on COSMIC side?

[nbdd0121]

It was an unstable feature that cosmic-design-demo used, but the feature was stablised in just 1.17 and unstable version removed in just 1.18. cosmic-design-demo's justfile hasn't been updated in the meanwhile.

[nyabinary]

It was an unstable feature that cosmic-design-demo used, but the feature was stablised in just 1.17 and unstable version removed in just 1.18. cosmic-design-demo's justfile hasn't been updated in the meanwhile.

i wonder if we can do a sed and replace that line for now?

[nbdd0121]

I just tested it, but unfortunately that's not sufficient. import is different from !include in terms of working directory -- the former uses the directory that contains the included file, and the later uses that of the including file.

[nyabinary]

I just tested it, but unfortunately that's not sufficient. import is different from !include in terms of working directory -- the former uses the directory that contains the included file, and the later uses that of the including file.

Maybe opening a PR for cosmic-design-demo and updating the justfile is the best option then.

[nyabinary]

I just tested it, but unfortunately that's not sufficient. import is different from !include in terms of working directory -- the former uses the directory that contains the included file, and the later uses that of the including file.

Been fixed now :)