Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdg-desktop-portal-cosmic: init at unstable-2023-12-07 #266697

Merged
merged 1 commit into from
Dec 9, 2023
Merged

xdg-desktop-portal-cosmic: init at unstable-2023-12-07 #266697

merged 1 commit into from
Dec 9, 2023

Conversation

nyabinary
Copy link
Contributor

Description of changes

Add xd directory & init xdg-desktop-portal-cosmic

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nyabinary nyabinary mentioned this pull request Nov 10, 2023
Open
31 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 10, 2023
@nyabinary nyabinary changed the title xdg-desktop-portal-cosmic: init at unstable-2023-10-11 xdg-desktop-portal-cosmic: init at unstable-2023-12-07 Dec 7, 2023
lilyinstarlight
lilyinstarlight reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to function with the one change suggested below

Thank you for working on this!

pkgs/by-name/xd/xdg-desktop-portal-cosmic/package.nix Show resolved Hide resolved
lilyinstarlight
lilyinstarlight approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, thank you!

@lilyinstarlight lilyinstarlight merged commit 8a55c06 into NixOS:master Dec 9, 2023
22 checks passed
@nyabinary nyabinary deleted the xdg-desktop-portal-cosmic branch December 9, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@lilyinstarlight lilyinstarlight lilyinstarlight approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyabinary @lilyinstarlight @jonringer