Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.05] win-dll-links: also copy dll from dependencies #267487

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-23.05, triggered by a label in #252459.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

Fixes running `pkgsCross.mingwW64._7zz` in wine.

Fixes issue 38451

```
tree result/bin
result/bin
├── 7zz.exe
└── mcfgthread-12.dll -> ../../wmgj476qjfw26f9aij1d64lxrjfv6kk0-mcfgthreads-x86_64-w64-mingw32-git/bin/mcfgthread-12.dll
```

Co-authored-by: marius david <marius@mariusdavid.fr>
(cherry picked from commit 1086f09)
@Ericson2314
Copy link
Member

Ericson2314 commented Nov 14, 2023

(I need this for building Nix with Windows and not having to collect all the dependency DLLs by hand.)

@Ericson2314 Ericson2314 merged commit 6aa551e into release-23.05 Nov 14, 2023
20 checks passed
@Ericson2314 Ericson2314 deleted the backport-252459-to-release-23.05 branch November 14, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants