Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixfmt: 0.5.0 -> 0.6.0 #268392

Closed
wants to merge 1 commit into from
Closed

nixfmt: 0.5.0 -> 0.6.0 #268392

wants to merge 1 commit into from

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented Nov 18, 2023

Description of changes

Update to latest release
Fixes numtide/treefmt-nix#99 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@SebTM
Copy link
Contributor Author

SebTM commented Nov 18, 2023

Result of nixpkgs-review pr 268392 run on x86_64-linux 1

1 package built:
  • nixfmt (nixfmt.bin ,nixfmt.doc)

Comment on lines +214459 to +214460
version = "0.6.0";
sha256 = "XwJ2A1Hzg4pznlWhxm1heCvinJgfBC5ZCTcaLC5D70k=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebTM Thanks for looking into this.

This file is actually automatically-generated, so any manual changes will get blown away.

nixfmt has already been updated to 0.6.0 in #266650, so it will be available in master when that PR is merged in.

@SebTM SebTM deleted the update/nixfmt_060 branch November 19, 2023 03:41
@SebTM
Copy link
Contributor Author

SebTM commented Nov 19, 2023

Hey, I see - didn't checked the date for the merge/23.11-branchoff which is the target of the MR if I understood correct and thought it would be more in the future ✌🏻

@cdepillabout
Copy link
Member

@SebTM I believe the current plan is to merge #266650 in before the branch off (although the branch-off date is very close, so now that I think about it, I'm not 100% sure we'll merge it in time).

If branch-off happens before #266650 is merged in, would you be able to open this PR again against the new release-23.11 branch (and make sure not to change pkgs/development/haskell-modules/hackage-packages.nix, but instead add the source override in pkgs/development/haskell-modules/configuration-common.nix)?

@SebTM
Copy link
Contributor Author

SebTM commented Nov 20, 2023

Wanted to answer now but already merged so not needed anymore to take care in branch-off? :)

@cdepillabout
Copy link
Member

@SebTM Yeah, I believe we got #266650 in time before branch-off, so this should hopefully not need to be taken care of :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixfmt always updates mtime
2 participants