Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog-d: init / justStaticExecutables #268487

Merged
merged 7 commits into from
Nov 19, 2023

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 19, 2023

Motivation

changelog-d had an unnecessarily large runtime closure.

Description of changes

  • Use justStaticExecutables
    • Make changelog-d a top level package
  • Refactor

The combined PR diff doesn't understand the file move, so it's easier to review individual commits.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 19, 2023
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is a minor breaking change, since e.g. haskellPackages.changelog-d.tests doesn't exist anymore. Same for updateScript and the -git- version suffix.

This is fairly internal however, so I guess it might be fine.

Otherwise this looks good!

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 19, 2023
@roberth
Copy link
Member Author

roberth commented Nov 19, 2023

Yeah, you'd have to use this git-only project as a library to find these changes. Basically you'd be asking for it.

@roberth roberth merged commit c7fe3b0 into NixOS:haskell-updates Nov 19, 2023
10 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.05:

Copy link
Contributor

Git push to origin failed for release-23.05 with exitcode 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants