-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog-d: init / justStaticExecutables
#268487
changelog-d: init / justStaticExecutables
#268487
Conversation
Move the overrides to top-level (pkgs/by-name).
I couldn't get the separate bin output to work.
79f1fa7
to
eb8dafd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this is a minor breaking change, since e.g. haskellPackages.changelog-d.tests
doesn't exist anymore. Same for updateScript
and the -git-
version suffix.
This is fairly internal however, so I guess it might be fine.
Otherwise this looks good!
Yeah, you'd have to use this git-only project as a library to find these changes. Basically you'd be asking for it. |
Successfully created backport PR for |
Git push to origin failed for release-23.05 with exitcode 1 |
Motivation
changelog-d
had an unnecessarily large runtime closure.Description of changes
justStaticExecutables
changelog-d
a top level packageThe combined PR diff doesn't understand the file move, so it's easier to review individual commits.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)