Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libressl: mark badPlatform on powerpc64le #268595

Merged
1 commit merged into from Jan 18, 2024
Merged

libressl: mark badPlatform on powerpc64le #268595

1 commit merged into from Jan 18, 2024

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2023

Description of changes

OpenBSD believes that PowerPC should be always-big-endian; this assumption seems to have propagated into recent releases of libressl. Since libressl is aliased to many other packages (e.g. netcat) it's important to fail early here, otherwise it's very difficult to figure out why libressl is getting dragged into a failing build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

OpenBSD believes that PowerPC should be always-big-endian; this
assumption seems to have propagated into recent releases of
libressl.  Since libressl is aliased to many other packages
(e.g. netcat) it's important to fail early here, otherwise it's very
difficult to figure out why libressl is getting dragged into a
failing build.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Nov 20, 2023
@ghost ghost marked this pull request as ready for review November 21, 2023 08:21
@ghost ghost requested a review from CrystalGamma December 1, 2023 02:41
@ghost
Copy link
Author

ghost commented Jan 18, 2024

@hlandau this is part of the fix for the issue you experienced.

@ghost ghost merged commit 8900543 into NixOS:master Jan 18, 2024
23 checks passed
@ghost ghost deleted the pr/libressl/powerpc64le-broken branch January 18, 2024 09:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants