utf8cpp_4: init at 4.0.2 #269374
Closed
utf8cpp_4: init at 4.0.2 #269374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lurkki14
suggested changes
Nov 24, 2023
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3045 |
pbsds
reviewed
Dec 7, 2023
| changelog = "https://github.com/nemtrif/utfcpp/releases/tag/v${version}"; | ||
| description = "UTF-8 with C++ in a Portable Way"; | ||
| license = licenses.boost; | ||
| maintainers = with maintainers; [ jobojeha ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = with maintainers; [ jobojeha ]; | |
| maintainers = with maintainers; [ aaronjheng ]; |
There was a problem hiding this comment.
I'm just a little helper. :)
I have the same question: why not upgrade the original? |
|
A breaking change was introduced in V4 building system. See nemtrif/utfcpp#112. I was not sure how big the impact will be. The 4.0.3 version released a few days ago appears to have fixed this issue. I will try to do a bump later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.