Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pulseaudio module #270677

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

lgoette
Copy link
Contributor

@lgoette lgoette commented Nov 28, 2023

Description of changes

  • Change pulseaudio module to set permission of pulse's home directory to 755 when running in "systemWide" mode
    -> The start-script of the pulseaudio daemon changes the permission to 755, but this gets reset on rebuild (with changes not regarding pulseaudio, so the daemon is not restarted)
    -> with the homeMode option, this gets set to 755 on rebuild

-> Fixes Issue, described in #114399

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lgoette
Copy link
Contributor Author

lgoette commented Nov 29, 2023

I know, it sounds weird to give a home directory 755 permissions but this is actually intended by pulseaudio as you can see here:
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/master/src/pulsecore/core-util.c#L1763-1771
Pulse sets the permission to 755 when running in system-wide mode and sets it to 700 otherwise.

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reword the commit message:

nixos/pulseaudio: set permission of pulse home directory

Closes #114399

nixos/doc/manual/release-notes/rl-2405.section.md Outdated Show resolved Hide resolved
@emilytrau emilytrau merged commit 580d1b0 into NixOS:master Dec 1, 2023
5 of 6 checks passed
@emilytrau
Copy link
Member

Rebased and merged. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants