ripgrep: fix shell completions when cross compiling

[uninsane]

Description of changes

#270521 fixed cross compilation but the result was missing shell completions. this patch fixes shell completions too.

$ nix build '.#ripgrep'
$ tree result
result
├── bin
│   └── rg
└── share
    ├── bash-completion
    │   └── completions
    │       └── rg.bash
    ├── fish
    │   └── vendor_completions.d
    │       └── rg.fish
    ├── man
    │   └── man1
    │       └── rg.1.gz
    └── zsh
        └── site-functions
            └── _rg

11 directories, 5 files

$ nix build '.#pkgsCross.aarch64-multiplatform.ripgrep'
$ tree result
result
├── bin
│   └── rg
└── share
    ├── bash-completion
    │   └── completions
    │       └── rg.bash
    ├── fish
    │   └── vendor_completions.d
    │       └── rg.fish
    ├── man
    │   └── man1
    │       └── rg.1.gz
    └── zsh
        └── site-functions
            └── _rg

11 directories, 5 files

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

[uninsane]

combed through the output of nix log ./result this time to make sure there weren't any non-fatal errors.

[Ma27]

The change in here looks good, however I spotted another issue: the installCheckPhase will never be run on cross builds (that's hard-wired in mkDerivation as I learned now and I'll open an issue for that).

I'm not keen on skipping a basic functionality test just because of some shortcomings in the current stdenv. A possible workaround which forces the face to be executed is

diff --git a/pkgs/tools/text/ripgrep/default.nix b/pkgs/tools/text/ripgrep/default.nix
index 8aa91640fd1f..b16b350757e4 100644
--- a/pkgs/tools/text/ripgrep/default.nix
+++ b/pkgs/tools/text/ripgrep/default.nix
@@ -42,7 +42,10 @@ in rustPlatform.buildRustPackage rec {
       --zsh <(${rg} --generate complete-zsh)
   '';
 
-  doInstallCheck = canRunRg;
+  postInstall = ''
+    export doInstallCheck=${toString canRunRg}
+  '';
+
   installCheckPhase = ''
     file="$(mktemp)"
     echo "abc\nbcd\ncde" > "$file"

Opinions?
cc @zowoq @globin @SuperSandro2000

[SuperSandro2000]

I don't really care if we run the tests on cross.

[Ma27]

Thanks!

And sorry for the long wait!