Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-bindgen-cli: 0.2.88 -> 0.2.89 #271267

Merged
merged 1 commit into from
Dec 1, 2023
Merged

wasm-bindgen-cli: 0.2.88 -> 0.2.89 #271267

merged 1 commit into from
Dec 1, 2023

Conversation

eclairevoyant
Copy link
Contributor

Description of changes

Bump version. Fixes #271256.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from Rizary and nitsky December 1, 2023 02:35
@NickCao
Copy link
Member

NickCao commented Dec 1, 2023

Result of nixpkgs-review pr 271267 run on x86_64-linux 1

1 package built:
  • wasm-bindgen-cli

@NickCao NickCao merged commit cae1e33 into NixOS:master Dec 1, 2023
26 checks passed
@eclairevoyant eclairevoyant deleted the wasm-bindgen-cli branch December 4, 2023 23:20
@v-kat
Copy link

v-kat commented Dec 7, 2023

Could this be backported to 23.11 given that rustwasm/wasm-bindgen#3685 and the yanked crate?

@github-actions github-actions bot mentioned this pull request Dec 7, 2023
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rizary Rizary Awaiting requested review from Rizary

@nitsky nitsky Awaiting requested review from nitsky

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: wasm-bindgen-cli 0.2.88 → 0.2.89
3 participants
@eclairevoyant @NickCao @v-kat