Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ct/tasks.nix: revert migration hack, invoke lib/tests/release.nix from single CT entry point #271819

Closed
wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2023

Please do not merge this until OfBorg has merged and deployed the following PR:

Adam Joseph added 4 commits December 2, 2023 22:12
This commit adds <nixpkgs/ct>, a single entry point for all
Continuous Testing (CT) runners, whether they are github, gerrit,
ofborg, or something else.

After merging this commit to create <nixpkgs/ct>, we will gradually
migrate the existing CT runners so that they use this interface and
*only* this interface.  This will ensure that all CT actions can be
reproduced locally by individual developers without needing access
to special infrastructure.
Ofborg is out-of-repo and has a much smaller (and therefore less
responsive) committer team.

Since it takes a long time to get them to merge and redeploy, this
commit adds a TEMPORARY call from lib/tests/release.nix to the
top-level ct entry point.

This commit should be reverted as soon as ofborg merges and deploys
the following PR, which will cause it to invoke the entry point
directly:

  #269356
Adam Joseph added 2 commits December 2, 2023 22:26
This test checks that what release-attrpaths-superset.nix calculates
is in fact a superset of the attributes which are calculated by the
much-slower ofborg method.

To run the test, invoke this command:

  nix-build pkgs/test/release/release-attrpaths-superset.nix -A failures

The result should be the empty list [].
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants