-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved makeOverridable #27319
Improved makeOverridable #27319
Changes from all commits
08021dd
927c4f8
af479c1
e11dbc3
5a5f861
8b76496
05f9db6
4d86038
dbd5009
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,26 +7,24 @@ | |
, configurationNix ? import ./configuration-nix.nix | ||
}: | ||
|
||
self: # Provided by `callPackageWithOutput` | ||
|
||
let | ||
|
||
inherit (lib) extends makeExtensible; | ||
inherit (haskellLib) overrideCabal makePackageSet; | ||
|
||
haskellPackages = pkgs.callPackage makePackageSet { | ||
package-set = initialPackages; | ||
inherit stdenv haskellLib ghc extensible-self; | ||
extensible-self = self; | ||
inherit stdenv haskellLib ghc; | ||
}; | ||
|
||
commonConfiguration = configurationCommon { inherit pkgs haskellLib; }; | ||
nixConfiguration = configurationNix { inherit pkgs haskellLib; }; | ||
|
||
extensible-self = makeExtensible | ||
(extends overrides | ||
(extends packageSetConfig | ||
(extends compilerConfig | ||
(extends commonConfiguration | ||
(extends nixConfiguration haskellPackages))))); | ||
|
||
in | ||
|
||
extensible-self | ||
in (extends overrides | ||
(extends packageSetConfig | ||
(extends compilerConfig | ||
(extends commonConfiguration | ||
(extends nixConfiguration haskellPackages))))) self | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That seems like the wrong thing to put there though? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll need to think about it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you talking about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attribute 'makeExtensibleWithInterface' missing, at ~/nixpkgs/lib/customisation.nix:84:6