Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fetchDartDeps #276414

Merged
merged 1 commit into from
Dec 25, 2023
Merged

fix fetchDartDeps #276414

merged 1 commit into from
Dec 25, 2023

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Dec 24, 2023

Description of changes

Use flutter for flutter package. I got The Flutter SDK is not available. error with dart. I guess #262789 broke something.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOS/flutter

Copy link
Contributor

@FlafyDev FlafyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I can now build localsend without it failing with "The Flutter SDK is not available.".
Where did you get "The Flutter SDK is not available."?

@linsui
Copy link
Contributor Author

linsui commented Dec 24, 2023

Where did you get "The Flutter SDK is not available."?

In the build log.

@FlafyDev
Copy link
Contributor

Where did you get "The Flutter SDK is not available."?

In the build log.

build log of your own package? Or of a package in nixpkgs?

@linsui
Copy link
Contributor Author

linsui commented Dec 24, 2023

build log of your own package? Or of a package in nixpkgs?

Build log of localsend. :)

Copy link
Member

@mkg20001 mkg20001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to "dart: fix fetchDartDeps"

@mkg20001 mkg20001 merged commit 2e3a121 into NixOS:master Dec 25, 2023
21 of 22 checks passed
@linsui linsui deleted the dart branch December 25, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants