Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmic-files: init at unstable-2024-01-12 #278745

Merged
merged 1 commit into from
Jan 12, 2024
Merged

cosmic-files: init at unstable-2024-01-12 #278745

merged 1 commit into from
Jan 12, 2024

Conversation

ahoneybun
Copy link
Contributor

@ahoneybun ahoneybun commented Jan 4, 2024 •
edited
Loading

Description of changes

This adds cosmic-files to unstable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ahoneybun ahoneybun marked this pull request as ready for review January 4, 2024 18:50
@ofborg ofborg bot requested a review from nyabinary January 4, 2024 19:14
@ahoneybun ahoneybun force-pushed the init-cosmic-files branch 4 times, most recently from 1582c41 to 46baec3 Compare January 4, 2024 21:20
nbdd0121
nbdd0121 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@nbdd0121 nbdd0121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well.

@ahoneybun ahoneybun force-pushed the init-cosmic-files branch 2 times, most recently from 7d6e56f to 7043d0a Compare January 5, 2024 13:32
@ziguana
Copy link
Contributor

ziguana commented Jan 7, 2024

working fine on hyprland for me

@nyabinary nyabinary mentioned this pull request Jan 11, 2024
Open
30 tasks
dunxen
dunxen approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 278745 run on x86_64-linux 1

1 package built: cosmic-files

Runs great on hyprland!

@ahoneybun ahoneybun changed the title cosmic-files: init at unstable-2024-01-04 cosmic-files: init at unstable-2024-01-12 Jan 12, 2024
@wegank wegank merged commit ab59beb into NixOS:master Jan 12, 2024
22 of 23 checks passed
@ahoneybun ahoneybun deleted the init-cosmic-files branch January 19, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunxen dunxen dunxen approved these changes

@nyabinary nyabinary Awaiting requested review from nyabinary

@nbdd0121 nbdd0121 Awaiting requested review from nbdd0121

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ahoneybun @ziguana @dunxen @nbdd0121 @delroth @wegank