Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.sip4: rename from sip_4 #279367

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Jan 7, 2024

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 279367 run on x86_64-linux 1

2 packages built:
  • python310Packages.sip4
  • python311Packages.sip4

@Stunkymonkey Stunkymonkey marked this pull request as ready for review January 7, 2024 15:16
Copy link
Member

@Cryolitia Cryolitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 packages built:
python310Packages.sip4 python311Packages.sip4

Result of nixpkgs-review pr 279367 run on x86_64-linux 1

2 packages built:
  • python310Packages.sip4
  • python311Packages.sip4

@Cryolitia Cryolitia added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 7, 2024
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2024
@Stunkymonkey Stunkymonkey merged commit e0fe536 into NixOS:master Jan 14, 2024
22 checks passed
@Stunkymonkey Stunkymonkey deleted the sip4-normalize branch January 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants