Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xsimd: disable on PowerPC (no Altivec, build fails) #279475

Closed
wants to merge 3 commits into from
Closed

xsimd: disable on PowerPC (no Altivec, build fails) #279475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b48f51e
xsimd: add isPower to badPlatforms
Jan 7, 2024
075ea0a
scipy: omit xsimd on platforms it does not support
Jan 7, 2024
335d427
pythran: omit xsimd on platforms it does not support
Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/development/libraries/xsimd/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,6 @@ stdenv.mkDerivation (finalAttrs: {
license = licenses.bsd3;
maintainers = with maintainers; [ tobim ];
platforms = platforms.all;
badPlatforms = [ lib.systems.inspect.patterns.isPower ]; # no AltiVec support, build fails
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't necessarily block this PR, but is upstream aware of this issue? Could we put a link here perhaps?

};
})
2 changes: 1 addition & 1 deletion pkgs/development/python-modules/pythran/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ in buildPythonPackage rec {
];

# xsimd: unvendor this header-only C++ lib
postPatch = ''
postPatch = lib.optionalString (lib.meta.availableOn stdenv.hostPlatform xsimd) ''
rm -r third_party/xsimd
ln -s '${lib.getDev xsimd}'/include/xsimd third_party/
'';
Expand Down
1 change: 1 addition & 0 deletions pkgs/development/python-modules/scipy/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ in buildPythonPackage {
lapack
pybind11
pooch
] ++ lib.optionals (lib.meta.availableOn stdenv.hostPlatform xsimd) [
xsimd
] ++ lib.optionals (pythonOlder "3.9") [
libxcrypt
Expand Down