-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frog: init at v0.13.7 #28036
frog: init at v0.13.7 #28036
Conversation
pkgs/top-level/all-packages.nix
Outdated
@@ -8432,6 +8432,8 @@ with pkgs; | |||
}; | |||
libkrb5 = krb5Full.override { type = "lib"; }; | |||
|
|||
languageMachines = import ../development/libraries/languagemachines/packages.nix { inherit callPackage; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is not part of the main namespace, the packages will be not build by hydra. Are you ok with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good point! I will make frog available at the top level. I don't think its dependencies are used a lot outside frog, so I think it doesn't make sense to put everything in the already big all-packages.nix
.
Is there a way to also include my test without polluting all-packages.nix
? (It's a simple runCommand
derivation that makes sure frog works as expected without a mutable frog.out
, lingering builder state, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add it to checkPhase
, so it will be run when the package is build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is not part of the main namespace, the packages will be not build by hydra
Its possible to use recurseIntoAttrs
410d6fc
to
0f9347c
Compare
Your test seems to be not working:
|
I would expect Travis CI to catch that. I will look into it. |
Alright, what happens is that nix-shell wants to run the output of the test. I have no idea why that happens, because for example
does not run the executable. I did't expect The following works and seems sufficient:
I think the nix-shell behaviour might be a bug. |
I guess it is ok then. |
Motivation for this change
frog is a natural language parser for dutch.
It depends on some other packages in the LanguageMachines organisation.
I have included an update script.
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)