-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdrpp: 1.0.4 -> 1.1.0-unstable-2024-01-22 #282448
Conversation
Looks like the pkgs/by-name check did get confused because the line in |
bb829fd
to
b99e41e
Compare
dc98857
to
ea66b97
Compare
Result of 1 package built:
|
ea66b97
to
79c92ae
Compare
Oh this is an interesting failure of the new Edit: CI fix in #283017 |
79c92ae
to
4fd9fd8
Compare
sdrpp switched to a rolling release, so take a git hash from head.
4fd9fd8
to
205038b
Compare
Anyone on this PR with the power to Approve/merge ? |
I can merge, @sikmir is this formally approved ? |
inherit (darwin.apple_sdk.frameworks) AppKit; | ||
}); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move it here:
}; | |
rtl-sdr = rtl-sdr-osmocom; # osmocom better w/ rtlsdr v4 | |
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think moving that configuration there is probably better done in a separate change.
sdrpp switched to a rolling release, so take a git hash from head.
rtl-sdr-osmocom
which is a newer superset ofrtl-sdr
(e.g. works better with rtl-sdr V4).Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.