Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.xformers: 0.03 -> 0.0.23.post1, add cuda support #285495

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

CertainLach
Copy link
Member

@CertainLach CertainLach commented Feb 1, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@CertainLach
Copy link
Member Author

Also something needs to be done with update script, as xformers was downgraded twice at this point:
image
#271586 (comment)

@Tungsten842
Copy link
Member

Could you update this to v0.0.24?

@CertainLach
Copy link
Member Author

I can, but I won't be able to test it this week.
I have only tested 0.0.23.post1 with vllm on A100.

@happysalada
Copy link
Contributor

Result of nixpkgs-review pr 285495 run on x86_64-linux 1

2 packages built:
  • python311Packages.xformers
  • python311Packages.xformers.dist

@CertainLach CertainLach force-pushed the xformers/update-0.0.23.post1 branch from b23cb40 to 364661d Compare February 3, 2024 13:07
@ofborg ofborg bot requested a review from happysalada February 3, 2024 13:44
@happysalada happysalada merged commit 84d1ae1 into NixOS:master Feb 3, 2024
19 checks passed
@happysalada
Copy link
Contributor

ok let's figure out the update script in a separate step.
Thank you for the contribution!
If you want to do the vllm init, feel free to tag me for it as well.

@CertainLach CertainLach deleted the xformers/update-0.0.23.post1 branch February 3, 2024 15:14
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set passthru.skipBulkUpdate = true to prevent this from happening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants