Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: 7.0.0 -> 7.0.2 #285544

Merged
merged 1 commit into from
Feb 17, 2024
Merged

bazel: 7.0.0 -> 7.0.2 #285544

merged 1 commit into from
Feb 17, 2024

Conversation

Strum355
Copy link
Contributor

@Strum355 Strum355 commented Feb 1, 2024

Description of changes

Changelog for 7.0.2: https://github.com/bazelbuild/bazel/releases/tag/7.0.2
List of commits between 7.0.0 and 7.0.2: bazelbuild/bazel@7.0.0...7.0.2

Most importantly perhaps, this bump fixes bazelbuild/bazel#20527.

This PR also includes provisions to enable overriding the version. Previously this wasnt trivial to do due to version being a locally scoped variable, so while the src could be updated, version was used in a few attributes via string interpolation that are more awkward to patch than it could be

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@flurie flurie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran nixpkgs-review and tested the Bazel binary on a few targets in large Bazel 7 project on x86_64-linux. I did not test the hermetic /tmp fix specifically, but I have had some users verify that 7.0.2 fixes the issue for them, so I am satisfied.

I can also run nixpkgs-review on aarch64-darwin, but I'm not sure how functional this is on darwin in general? The meta info indicates it is.

@malt3
Copy link
Contributor

malt3 commented Feb 16, 2024

Do you think it makes sense to add this patch back? https://github.com/sourcegraph/sourcegraph/pull/59359

I also ran into it for multiple Bazel projects.

@Strum355
Copy link
Contributor Author

Do you think it makes sense to add this patch back? sourcegraph/sourcegraph#59359

I also ran into it for multiple Bazel projects.

I would be tempted to put in a separate PR, although theres some unfinished discussion on the topic here: #262152

@Strum355
Copy link
Contributor Author

@layus @wegank sorry for the ping, would we be able to merge this?

@layus layus merged commit b03b835 into NixOS:master Feb 17, 2024
23 checks passed
@layus layus mentioned this pull request Feb 17, 2024
@layus
Copy link
Member

layus commented Feb 17, 2024

Yes, sure :-).
@Strum355 Thanks for the PR
@malt3, @flurie Thanks for testing this toroughly
@malt3 I did investigate the PATH issues quite a lot. Let's move the discussion to #289505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel 7: --sandbox_add_mount_pair under /tmp fails
4 participants