build-support/php: set COMPOSER_ROOT_VERSION environment variable

[drupol]

This PR:

• Create a bash file containing useful functions used in both hooks
• Switch some derivations to using buildComposerProject wrapper
• Fix and bump PHP-Parallel-Lint (cannot use 1.3.2 any more because nette/tester doesn't exist any more, see php-parallel-lint/PHP-Parallel-Lint@11d8c51#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34 and there is no new tag ever since, see Adding composer.lock under VCS ? php-parallel-lint/PHP-Parallel-Lint#153)
• Bump PSalm to 5.22.1 (This PR yields Update .gitattributes vimeo/psalm#10645 which has yield Drop unused local composer repo vimeo/psalm#10647)
• add php-codesniffer built from sources now, deprecate phpcs and phpcbf which depends on php-codesniffer now
• Bump a couple of other derivations

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[LeSuisse]

The broken ofborg-eval is somehow "normal" since we are throwing a warning for phpcs and phpcbf.

I do not think we can we use this pattern for packages. It is probably good enough to remove the packages and to set an alias to give some information. The phpcs and phpcbf derivations will need to be dropped at some point so might as well do it now.

diff --git a/pkgs/top-level/php-packages.nix b/pkgs/top-level/php-packages.nix
index 5647ccfd349c..310c9417fef4 100644
--- a/pkgs/top-level/php-packages.nix
+++ b/pkgs/top-level/php-packages.nix
@@ -204,10 +204,6 @@ lib.makeScope pkgs.newScope (self: with self; {
 
     php-parallel-lint = callPackage ../development/php-packages/php-parallel-lint { };
 
-    phpcbf = lib.warn "`phpcbf` is now deprecated, use `php-codesniffer` instead which contains both `phpcs` and `phpcbf`." (callPackage ../development/php-packages/phpcbf { });
-
-    phpcs = lib.warn "`phpcs` is now deprecated, use `php-codesniffer` instead which contains both `phpcs` and `phpcbf`." (callPackage ../development/php-packages/phpcs { });
-
     phpmd = callPackage ../development/php-packages/phpmd { };
 
     phpspy = callPackage ../development/php-packages/phpspy { };
@@ -217,6 +213,9 @@ lib.makeScope pkgs.newScope (self: with self; {
     psalm = callPackage ../development/php-packages/psalm { };
 
     psysh = callPackage ../development/php-packages/psysh { };
+  } // lib.optionalAttrs config.allowAliases {
+    phpcbf = throw "`phpcbf` is now deprecated, use `php-codesniffer` instead which contains both `phpcs` and `phpcbf`."; # Added 25-02-2024
+    phpcs = throw "`phpcs` is now deprecated, use `php-codesniffer` instead which contains both `phpcs` and `phpcbf`."; # Added 25-02-2024
   };

[drupol]

@ofborg build phpPackages.psalm phpPackages.php-parallel-lint phpPackages.php-codesniffer phpPackages.phpcs phpPackages.phpcbf phpPackages.deployer phpPackages.phan phpPackages.phing phpPackages.phive phpPackages.php-cs-fixer phpPackages.phpmd phpPackages.n98-magerun phpPackages.n98-magerun2

[LeSuisse]

Changes looks good, no unexpected failure.

Result of nixpkgs-review pr 285828 run on x86_64-linux 1

3 packages failed to build:

• php81Packages.php-codesniffer
• php81Packages.psalm
• php83Packages.deployer

59 packages built:

• adminer
• bookstack
• composer-require-checker
• librenms
• movim
• n98-magerun
• n98-magerun2
• paratest
• pdepend
• pest
• phel
• php81Packages.box (php82Packages.box ,php83Packages.box)
• php81Packages.castor
• php81Packages.composer
• php81Packages.deployer
• php81Packages.grumphp
• php81Packages.phan
• php81Packages.phing
• php81Packages.phive
• php81Packages.php-cs-fixer
• php81Packages.php-parallel-lint
• php81Packages.phpmd
• php81Packages.phpstan
• php81Packages.psysh
• php82Packages.castor
• php82Packages.composer
• php82Packages.deployer
• php82Packages.grumphp
• php82Packages.phan
• php82Packages.phing
• php82Packages.phive
• php82Packages.php-codesniffer
• php82Packages.php-cs-fixer
• php82Packages.php-parallel-lint
• php82Packages.phpmd
• php82Packages.phpstan
• php82Packages.psalm
• php82Packages.psysh
• php83Packages.castor
• php83Packages.composer
• php83Packages.grumphp
• php83Packages.phan
• php83Packages.phing
• php83Packages.phive
• php83Packages.php-codesniffer
• php83Packages.php-cs-fixer
• php83Packages.php-parallel-lint
• php83Packages.phpmd
• php83Packages.phpstan
• php83Packages.psalm
• php83Packages.psysh
• phpactor
• phpdocumentor
• phpunit
• pixelfed
• platformsh
• robo
• snipe-it
• vimPlugins.phpactor

[github-actions]

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-285828-to-release-23.11 origin/release-23.11
cd .worktree/backport-285828-to-release-23.11
git switch --create backport-285828-to-release-23.11
git cherry-pick -x f43fb4c110836bcbbbb5e6265f0d05293b819d7d f4c31eb9c516d2df638fe82ffac2b2dffac2e00c 5949927f4d48b1fd6c27340029a50b861c99624c 8d0197fe1e40da9365a3e2af51309feb52de0f6f 7491aa43a777881766e02f32c0e42b263d0a2469 d653d7800fef3b6b43aa695bdb7382eebb9990d2 b7f3d0df8fb5cc7994aa04ca7552dff6dcd98cf1 dae4e32f4b046943e3913f9dde7bebbcc2b1821b 68866194354da5cc7cf69914049c30b57c93f02b ee4ecc331b0b691500ec293959a88da9d5e2873a 42be235ec004c9fe3579ca9ef3ea29f47e92f673 b453c845f6fbf9053a046d44406d987bc1613c7e 7e3f284f13d90495963017c4b9d333b7440256c1 6addd0822026c2d1f406d8c9b5d0398c6ec382d9 ddb92f079f20a7d67c018ae3dd0a38fd1318753f