retdec: 3.2 -> 5.0 #285950
Merged
retdec: 3.2 -> 5.0 #285950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timokau
requested changes
Feb 3, 2024
katrinafyi
force-pushed
the
master
branch
2 times, most recently
from
53eec0a
to
d1be798
Compare
|
Addressed changes (use absolute patch url and change maintainers) @timokau I had a question, does anything else need to be done to obsolete the retdec-full package? |
|
Fixed build failure due to stale hash. |
|
Thanks again! Regarding |
timokau
reviewed
Feb 4, 2024
| name = "katrinafyi"; | ||
| github = "katrinafyi"; | ||
| githubId = 39479354; | ||
| }; |
There was a problem hiding this comment.
Welcome to the maintainers team 🎉
- Bumps vendored dependencies and remove ones no longer needed. - Since 3.3, compiled patterns are not shipped in the support file, obviating the postFetch strip. (avast/retdec-support#3) - Now, patterns may be compiled at build time and an argument is provided to control this (on by default). - As such, retdec-full is no longer needed and removed. The 60MB increase seems more preferred than duplicating the 500MB size. - We use cmake _URL variables to insert dependencies and we are able to use nixpkgs googletest. - Fix build with current gcc 13. - Remove i686 from platforms, as derivation needs to specify lib64. - Maintainers: remove timokau, add katrinafyi.
since version 5.0, compiled yara patterns are included with the retdec package so retdec-full is no longer needed.
|
Formally removed retdec-full. |
timokau
approved these changes
Feb 5, 2024
kirillrdy
reviewed
Apr 1, 2024
| --replace-quiet VersionTests DISABLED_VersionTests | ||
|
|
||
| substituteInPlace scripts/retdec-utils.py \ | ||
| --replace-warn /usr/bin/time ${time} \ |
There was a problem hiding this comment.
any reason not to use --replace-fail here ?
There was a problem hiding this comment.
Not really, and it would be good to fail more obviously here. I have an open PR for this package (#293962) and I can make the changes there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/avast/retdec/blob/master/CHANGELOG.md
On my laptop, this package takes 30 minutes to build. Half of this is the fork of LLVM.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)cc maintainers: @timokau @dtzWill
Add a 👍 reaction to pull requests you find important.