Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mission-center: 0.4.3 -> 0.4.4 #287820

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Feb 10, 2024

Description of changes

Changelog: https://gitlab.com/mission-center-devs/mission-center/-/releases/v0.4.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 287820 run on x86_64-linux 1

1 package built:
  • mission-center

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 287820 run on aarch64-linux 1

1 package built:
  • mission-center

@GaetanLepage GaetanLepage requested a review from wegank February 10, 2024 17:07
@GaetanLepage
Copy link
Contributor Author

The program runs as expected on my laptop.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 10, 2024
@wegank
Copy link
Member

wegank commented Feb 10, 2024

Result of nixpkgs-review pr 287820 run on aarch64-linux 1

1 package built:
  • mission-center

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 10, 2024
@amaxine amaxine merged commit 08d24f8 into NixOS:master Feb 11, 2024
34 checks passed
@GaetanLepage GaetanLepage deleted the mission-center branch February 11, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants