rustPlatform.maturinBuildHook: specify the output directory #291025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
force-pushed
the
pr/cramjam_2_8_1
branch
from
06890d1
to
0ae3d92
Compare
|
Result of 144 packages marked as broken and skipped:
1439 packages failed to build:
10222 packages built: |
|
Already on staging via python-updates: e37dca9 |
|
@mweinelt Any thoughts on maturinBuildHook change? (btw, I'm a bit surprised that you were able to work it around, @natsukium ) |
|
No, to be honest I only hack around on it, when things fail. If you think your solution is cleaner we can certainly switch things around. |
|
I just tried |
veprbl
force-pushed
the
pr/cramjam_2_8_1
branch
from
2177a4e
to
2eb3bfa
Compare
veprbl
changed the title
veprbl
changed the title
|
I've removed the second commit. |
I did try that one, but it failed (IIRC it looked like it picked up the wrong workspace lock file, which was inconsistent with the cargoDeps one). But okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
bumps package version
TODO:
patchesto apply Cargo.toml: set workspace.resolver to 2 milesgranger/cramjam#140Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.