Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault, vault-bin: 1.15.5 -> 1.15.6 #292848

Merged
merged 2 commits into from
Mar 2, 2024
Merged

vault, vault-bin: 1.15.5 -> 1.15.6 #292848

merged 2 commits into from
Mar 2, 2024

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Mar 2, 2024

Description of changes

One security fix: hashicorp/vault#25649

Changes:
https://github.com/hashicorp/vault/releases/tag/v1.15.6

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol merged commit 14784eb into NixOS:master Mar 2, 2024
25 of 26 checks passed
@LeSuisse LeSuisse deleted the vault-1.15.6 branch March 3, 2024 15:56
@CobaltCause
Copy link
Contributor

Hmm, I don't end up with the same hash for vendorHash when I try to build vault:

$ NIXPKGS_ALLOW_UNFREE=1 nix build --impure 'github:NixOS/nixpkgs?ref=nixos-unstable#vault'
error: hash mismatch in fixed-output derivation '/nix/store/ja3s1qlx3p23i7awymfvm7yf9h492kx7-vault-1.15.6-go-modules.drv':
         specified: sha256-SYGqlLCA7T4MhRlOVBSYnZdZ2+WuJvmmHw3MdnfoezM=
            got:    sha256-97/nNRwTJnoW1gRvWhdsO36TuLdGTX67o0oTiGMotrs=
error: 1 dependencies of derivation '/nix/store/bvgq4agqgghadzgdjrcis9qb4jwz8c8g-vault-1.15.6.drv' failed to build

@mjm
Copy link
Contributor

mjm commented Mar 22, 2024

Pretty sure this is happening due to buildGoModule being updated to Go 1.22. it seems to change the vendor hashes in some cases.

@CobaltCause CobaltCause mentioned this pull request Mar 23, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants