Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixfmt-rfc-style: apply serokell/nixfmt#133 #294342

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Mar 8, 2024

Description of changes

This fixes invocations of nixfmt in ci with treefmt --fail-on-change

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@r-vdp
Copy link
Contributor

r-vdp commented Mar 8, 2024

Ironically, the indentation of the fetchpatch invocation looks a bit off.

@0x4A6F
Copy link
Member Author

0x4A6F commented Mar 8, 2024

It is, forgot to format my own contributions. That is normally a job for CI and not for a tired human like myself. ;)

@0x4A6F 0x4A6F force-pushed the master-nixfmt-rfc-style branch from d13c043 to 62a7cc5 Compare March 8, 2024 20:09
@dasJ dasJ merged commit fc405ec into NixOS:master Mar 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants