Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-llvm-cov: 0.6.7 -> 0.6.9 #296387

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

matthiasbeyer
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@CobaltCause CobaltCause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, as usual. Tested the new --branch option for branch coverage by getting rustc 1.78.0-nightly (c67326b06 2024-03-15) from fenix, and it seems to work too. (I guess the PR description here saying it needs "2024-03-16+" was just a typo? This is expected.)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 19, 2024
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer matthiasbeyer changed the title cargo-llvm-cov: 0.6.7 -> 0.6.8 cargo-llvm-cov: 0.6.7 -> 0.6.9 Apr 7, 2024
@ofborg ofborg bot requested a review from CobaltCause April 7, 2024 07:55
@matthiasbeyer
Copy link
Contributor Author

Result of nixpkgs-review pr 296387 run on x86_64-linux 1

1 package built:
  • cargo-llvm-cov

@matthiasbeyer matthiasbeyer merged commit 0777afc into NixOS:master Apr 7, 2024
20 of 22 checks passed
@matthiasbeyer matthiasbeyer deleted the update-cargo-llvm-cov branch April 7, 2024 08:02
Copy link
Contributor

github-actions bot commented Apr 7, 2024

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-296387-to-release-23.11 origin/release-23.11
cd .worktree/backport-296387-to-release-23.11
git switch --create backport-296387-to-release-23.11
git cherry-pick -x fb8e5de27339bf3858c88bab9a847f6e0baad2db 3be04b33601485716f1053fbb9c4496333a62138

@matthiasbeyer
Copy link
Contributor Author

Backport picked to #298302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants