Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmenu, slstatus, st, dwm, slock: add updateScript #297748

Closed
wants to merge 1 commit into from

Conversation

Qusic
Copy link
Member

@Qusic Qusic commented Mar 21, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Mar 21, 2024
@AndersonTorres
Copy link
Member

Split the packages into dedicated commits.

Indeed I would suggest one for each PR.

@Qusic Qusic closed this Mar 22, 2024
@AndersonTorres
Copy link
Member

A suggestion of workflow:

  1. In your local copy, synchronize master
  2. Create and checkout a branch called (say) maintainers-add-qusic
  3. In add-qusic-to-maintainers create a commit adding qusic to maintainers
  4. For each package P you want to adopt
    1. Create a new branch from maintainers-add-qusic called P-adopt
    2. Create a commit doing your changes

Then, create PRs for each of those commits.
However, you will mark all as draft except the maintainers-add-qusic, and you will explain that your intention is to became the new maintainer of the P-adopt packages.

What do you think?

The idea is that you can rebase them later more easily without the need for waiting for you being added to maintainers first.

@Qusic
Copy link
Member Author

Qusic commented Mar 22, 2024

@AndersonTorres Thanks for the tip! I am out this weekend without my PC and will create separate PRs next week. I close this for now so CI validations can stop and free up some resources.

@Qusic Qusic deleted the updater branch April 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants