Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo,clippy,rustc,rustfmt: 1.76.0 -> 1.77.1 #298340

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Mar 23, 2024

Description of changes

Tested fd on aarch64-linux, and firefox, thunderbird, and fd on x86_64-linux.

Still looking for somebody to test fd on x86_64-darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zowoq
Copy link
Contributor

zowoq commented Mar 24, 2024

Build fd on x86_64-darwin.

@workingjubilee
Copy link

workingjubilee commented Mar 27, 2024

you may wish to be aware of #299606 but it is non-blocking I think, since it seems to require other variables to be involved in order to mess things up, and may not necessarily be considered a problem for ordinary use of nixpkgs.

also we're doing a point release tomorrow to fix a related bug, but only for Windows: rust-lang/rust#122857 but maybe that matters for cross-compiling, idk.

relevant original blog post explaining the motivation: https://kobzol.github.io/rust/cargo/2024/01/23/making-rust-binaries-smaller-by-default.html

@sdht0
Copy link
Contributor

sdht0 commented Mar 31, 2024

@winterqt
Copy link
Member

Probably fine just to skip that point release, given it only affects MSVC?

@rcrowe rcrowe mentioned this pull request Mar 31, 2024
14 tasks
@sdht0
Copy link
Contributor

sdht0 commented Mar 31, 2024

Probably fine just to skip that point release, given it only affects MSVC?

Practically yes. OTOH repology will show the nixpkgs version to be outdated until the next release, for instance. Fine either ways.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 31, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 1, 2024
@alyssais alyssais changed the title cargo,clippy,rustc,rustfmt: 1.76.0 -> 1.77.0 cargo,clippy,rustc,rustfmt: 1.76.0 -> 1.77.1 Apr 3, 2024
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Apr 4, 2024
@roblabla roblabla mentioned this pull request Apr 4, 2024
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 5, 2024
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Requires a rebase, but other than that it looks good to me 👍

pkgs/os-specific/linux/kernel/patches.nix Show resolved Hide resolved
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Apr 6, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 8, 2024
@ofborg ofborg bot requested a review from Ma27 April 8, 2024 17:36
@wegank wegank removed the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Apr 9, 2024
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be merged now?

@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Apr 9, 2024
@Ma27 Ma27 merged commit 936c4d7 into NixOS:staging Apr 10, 2024
25 checks passed
link2xt added a commit to deltachat/deltachat-core-rust that referenced this pull request Apr 10, 2024
Update to Rust 1.77 since
<NixOS/nixpkgs#298340>
is merged.
@phaer phaer mentioned this pull request Apr 12, 2024
13 tasks
@alyssais alyssais deleted the rust-1.77.0 branch May 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 6.topic: rust 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants