-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo,clippy,rustc,rustfmt: 1.76.0 -> 1.77.1 #298340
Conversation
Build fd on x86_64-darwin. |
5868204
to
b5988d5
Compare
you may wish to be aware of #299606 but it is non-blocking I think, since it seems to require other variables to be involved in order to mess things up, and may not necessarily be considered a problem for ordinary use of nixpkgs. also we're doing a point release tomorrow to fix a related bug, but only for Windows: rust-lang/rust#122857 but maybe that matters for cross-compiling, idk. relevant original blog post explaining the motivation: https://kobzol.github.io/rust/cargo/2024/01/23/making-rust-binaries-smaller-by-default.html |
Probably fine just to skip that point release, given it only affects MSVC? |
Practically yes. OTOH repology will show the nixpkgs version to be outdated until the next release, for instance. Fine either ways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Requires a rebase, but other than that it looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be merged now?
Update to Rust 1.77 since <NixOS/nixpkgs#298340> is merged.
Description of changes
Tested fd on aarch64-linux, and firefox, thunderbird, and fd on x86_64-linux.
Still looking for somebody to test fd on x86_64-darwin.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.