Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickwit: 0.6.4 -> 0.8.0 #298589

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

happysalada
Copy link
Contributor

Description of changes

simple update , @kvtb thank you for the fix!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 24, 2024
@happysalada happysalada merged commit dba0006 into NixOS:master Mar 27, 2024
21 checks passed
@happysalada happysalada deleted the update_quickwit branch March 27, 2024 21:26
@nh2
Copy link
Contributor

nh2 commented Apr 1, 2024

@happysalada This does not build for me or for Hydra:

error: A hash was specified for chitchat-0.8.0, but there is no corresponding git dependency.

@nh2
Copy link
Contributor

nh2 commented Apr 1, 2024

Looks like a missing git add on the new Cargo.lock, it evaluates when taking the one from https://raw.githubusercontent.com/quickwit-oss/quickwit/v0.8.0/quickwit/Cargo.lock

nh2 added a commit to nh2/nixpkgs that referenced this pull request Apr 1, 2024
It was forgotten to be updated with the last update from NixOS#298589.
Fixes eval.
@nh2 nh2 mentioned this pull request Apr 1, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants