auditBlasHook: remove #301011
Merged
auditBlasHook: remove #301011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in NixOS@d83e9c9, but included substitution variables `@blas@` and `@lapack@` that were never substituted. It's not used anywhere in `nixpkgs`.
philiptaron
requested review from
SuperSandro2000,
K900,
Ericson2314 and
matthewbauer
and removed request for
Ericson2314
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
ghost
approved these changes
Apr 2, 2024
|
Or should we fix it instead? Is this hook even useful? |
🤷🏻♂️Not having any users in four-ish years is a pretty good indication that we can live without it, and it'll always be in the source history if someone figures out how to make it useful (ideally, with docs and worked examples in the nixpkgs tree.) I'm not the one to do that work, though; I'm just the janitor in this PR. |
|
removing it seems fine. i think |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This was added in d83e9c9 (part of #83888), but included substitution variables
@blas@and@lapack@that were never substituted. It's not used anywhere innixpkgs.Things done
nixpkgs-review rev HEAD(nothing rebuilt)