crystal: 1.11 -> 1.14 #303173
crystal: 1.11 -> 1.14 #303173
Conversation
|
You'll want to rebase on the latest |
will
force-pushed
the
update-crystal-1.12
branch
from
530e657 to
cafe807
Compare
ofborg
bot
requested review from
donovanglover,
manveru,
david50407 and
peterhoeg
|
I've also now fixed crystalline by making sure to pick the same version of llvm. And I've patched a type error in invidious that I would assume they'll get to eventually in a new version and nixpkgs can drop that small patch when it updates to a newer version of invidious. The Result of 2 packages marked as broken and skipped:
23 packages built:
|
|
We don't share homebrew's problems, but I just want to bring attention to crystal-lang/crystal#14318 to see if anyone has any issues that this might solve. |
|
@peterhoeg I saw that patch too, and while I'm not 100% sure, I think think the long stdenv wrapper scripts around the linker and whatnot take care of the problems that patch is trying to address |
will
force-pushed
the
update-crystal-1.12
branch
from
cafe30b to
cafef58
Compare
|
I can't compile anything on EndeavourOS regardless of crystal version nix-build -A tijolo
this derivation will be built:
/nix/store/pwlcp6r8x2lwg6d0xq0aficw319nj3bw-tijolo-0.7.4.drv
building '/nix/store/pwlcp6r8x2lwg6d0xq0aficw319nj3bw-tijolo-0.7.4.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/qiv3kriqmw0i5kpqrgaqsb1nbrr6a1bx-source
source root is source
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: configurePhase
Running phase: buildPhase
shards build --release -s -Dpreview_mt --ignore-crystal-version
Dependencies are satisfied
Building: tijolo
Parse: 00:00:00.000122163 ( 1.07MB)
Error target tijolo failed to compile:
impure path `/homeless-shelter/.cache/crystal/build-source-lib-version_from_shard-src-extract_version.cr/macro_run' used in link
collect2: error: ld returned 1 exit status
Error: execution of command failed with exit status 1: gcc "${@}" -o /homeless-shelter/.cache/crystal/build-source-lib-version_from_shard-src-extract_version.cr/macro_run -rdynamic -L/nix/store/vyz5cpkg7rli3236cy30dald1yj9mdch-boehm-gc-8.2.4/lib -L/nix/store/5sqdrc4jpr4vjiiqycyw8q4v3zchpdka-pcre2-10.43/lib -L/nix/store/jlqg0qc06nas4qcpqn8w9nnkgsvrxjxp-libevent-2.1.12/lib -L/nix/store/pqjjikxz0xb7g79gj1h75qbgxg2xkbkz-libyaml-0.2.5/lib -L/nix/store/zph9xw0drmq3rl2ik5slg0n2frw9lw5m-zlib-1.3.1/lib -L/nix/store/ii7r1shwrbl9rcv6nn6mfvih5qcb742p-libxml2-2.12.6/lib -L/nix/store/p25ghy7y53lyc834xnw5mrhfq096wa4x-openssl-3.0.13/lib -L/nix/store/pqjjikxz0xb7g79gj1h75qbgxg2xkbkz-libyaml-0.2.5/lib -lyaml -lpcre2-8 -L/nix/store/vyz5cpkg7rli3236cy30dald1yj9mdch-boehm-gc-8.2.4/lib -lgc -lpthread -ldl -lpthread -L/nix/store/jlqg0qc06nas4qcpqn8w9nnkgsvrxjxp-libevent-2.1.12/lib -levent_pthreads -levent -L/nix/store/jlqg0qc06nas4qcpqn8w9nnkgsvrxjxp-libevent-2.1.12/lib -levent -lrt -lpthread -ldl
make: *** [Makefile:5: all] Error 1
error: builder for '/nix/store/pwlcp6r8x2lwg6d0xq0aficw319nj3bw-tijolo-0.7.4.drv' failed with exit code 2Probably it is a non-nixos issue, but I think this shouldn't happen. |
While updating crystal for 1.14 this project breaks with
In src/code_language.cr:46:18
46 | mime = Gio.content_type_guess(file.to_s, contents[0, contents_size])
^-----------------
Error: wrong number of arguments for 'Gio.content_type_guess' (given 2, expected 4)
Overloads are:
- Gio.content_type_guess(filename : ::String, data : Pointer(UInt8), data_size : UInt64, result_uncertain : Pointer(Bool))
will
force-pushed
the
update-crystal-1.12
branch
from
cafef58 to
cafef48
Compare
|
Updated this pr to change to crystal 1.14 now |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4669 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/ysk-guide-on-getting-your-pr-merged/54513/2 |
|
|
Seems to fail during In lib/markd/src/markd/renderers/html_renderer.cr:238:7
238 | {% if Crystal::VERSION < "1.2.0" %}
^
Warning: expanding macro
There was a problem expanding macro 'macro_140735611328032'
Called macro defined in lib/markd/src/markd/renderers/html_renderer.cr:238:7
238 | {% if Crystal::VERSION < "1.2.0" %}
Which expanded to:
1 |
> 2 | title = URI.encode(node.first_child.text)
3 | @output_io << %(<a id="anchor-) << title << %(" class="anchor" href="#anchor-) << title << %("></a>)
4 |
Warning: Deprecated URI.encode. Use `.encode_path` instead.
A total of 1 warnings were found.Could add |
donovanglover
added
the
6.topic: crystal
|
Warnings should really not break a build. They're just warnings. |
|
Seems to be caused by |
|
@donovanglover thanks so much for taking the time to check this! I just got ahold of an x86 linux VM and am seeing if I can figure out what's up |
|
FWIW I'm okay with disabling |
Oh okay, I pushed up a commit with doCheck false, and everything else built fine:
|
donovanglover
added
12.approvals: 1
|
Thanks @donovanglover for all the time and help with this! |
Current Description of changes
Release notes: https://crystal-lang.org/2024/10/09/1.14.0-released/
Old Description of changes
Release notes: https://crystal-lang.org/2024/04/09/1.12.0-released
From the notes:
So I've updated the llvm package for this version to llvm 18. From talking with people on the Crystal core team, there is very small chance that the 16-bit alignment for 128-bit integers in llvm18 can cause problems on x86 systems (not aarch64 since they already were using 16-bit alignment), and if so we should go down to llvm 17.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageResult of
nixpkgs-reviewrun on aarch64-darwin 11 package marked as broken and skipped:
3 packages failed to build:
18 packages built:
./result/bin/)Add a 👍 reaction to pull requests you find important.