matrix-synapse-tools.rust-synapse-compress-state: 0.1.3 -> 0.1.4

[amesgen]

Description of changes

https://github.com/matrix-org/rust-synapse-compress-state/releases/tag/v0.1.4

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[maralorn]

Thank you!

Diff looks okay, package builds and executable seems to be working. Haven’t tested it on a real db, but issues there wouldn’t seem packaging related.

What’s the issue with the lock file? I have no clue of rust packaging best practices. That’s a lot of data to check-in. Is this the recommended way now? Is there a reason that the cargoHash solution does not work anymore?

Edit: I have been notified that the lock file is needed because a dependency is a git reference with missing hash.

[Erethon]

What’s the issue with the lock file? I have no clue of rust packaging best practices. That’s a lot of data to check-in. Is this the recommended way now? Is there a reason that the cargoHash solution does not work anymore?

Edit: I have been notified that the lock file is needed because a dependency is a git reference with missing hash.

I pinned the git reference dependency upstream, so the next version of the package won't need the Cargo lock hopefully.

[amesgen]

What’s the issue with the lock file? I have no clue of rust packaging best practices. That’s a lot of data to check-in. Is this the recommended way now? Is there a reason that the cargoHash solution does not work anymore?
Edit: I have been notified that the lock file is needed because a dependency is a git reference with missing hash.

I pinned the git reference dependency upstream, so the next version of the package won't need the Cargo lock hopefully.

Thanks, though this sadly won't allow us to remove the Cargo.lock as there still is no integrity hash in Cargo.lock for the git dependency; only removing all git dependencies will allow de-vendoring Cargo.lock again.

Forbidding git deps without outputHashes was added in #221716 (4329de1), which was after the last update to rust-synapse-compress-state in #184556. It only works ATM (ie before this PR) as the FOD is cached, ie

nix-build -A matrix-synapse-tools.rust-synapse-compress-state.cargoDeps

succeeds as it will be fetched from cache.nixos.org, but

nix-build -A matrix-synapse-tools.rust-synapse-compress-state.cargoDeps --check

fails with

ERROR: The Cargo.lock contains git dependencies

[maralorn]

Well, thanks for reminding me of this PR. This has simmered long enough now.