Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circt: 1.72.0 -> 1.73.0 #305176

Merged
merged 1 commit into from
Apr 19, 2024
Merged

circt: 1.72.0 -> 1.73.0 #305176

merged 1 commit into from
Apr 19, 2024

Conversation

sequencer
Copy link
Contributor

@sequencer sequencer commented Apr 19, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao
Copy link
Member

NickCao commented Apr 19, 2024

@ofborg build circt

@sequencer
Copy link
Contributor Author

LLVM test failed:
https://logs.ofborg.org/?key=nixos/nixpkgs.305176&attempt_id=7746b96f-d83f-4658-a57c-2c3954e9c345

Has been fixed in:
llvm/llvm-project#89318

It doesn't affect circt function, thus safe to waive this issue.
It is included in the next version of circt.

@NickCao NickCao merged commit 83c0ee6 into NixOS:master Apr 19, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants