-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixVersions.unstable: build from master, re-init at 2.22.0.pre20240321_6fd2f42c #305951
Conversation
I'm AOK with this, I kind of want a |
I think it should be
I don't think we need to backport such updates at all. Interested people should use the unstable channel for frequent updates already. There's not much to be gained from backporting this imo. |
Given that master claims to be always releasable and we already had quite a bunch of regressions on the last releases, I wasn't sure if that makes that much of a difference. But I see your point. But if a majority of people prefers a change, I'd say we go with
There's one thing I don't want to end up with: having a So we'll either drop it after every branchoff or backport each change, I'd be fine with both. |
Perhaps i would be possible to have a package In any case, overall I think it is reasonable to have this type of package. Backwards incompatibilities and other similar breakage is very stressful when they are discovered after a release. It so happens to be that I've been working a little on creating some basic integration tests for Home Manager ( |
97aa29b
to
07c6fce
Compare
Added
Sounds good, but I don't think that this should be an ad-hoc addition here. This looks relevant for every -git variant of a package (e.g. zfs or llvm). For now, I'm inclined to just backport all attributes, including .git. |
07c6fce
to
2c6cf67
Compare
…1_6fd2f42c The idea behind that is to enable users and developers of downstream tools such as home-manager to test Nix master for several reasons: * Nix is currently trying to have a `master` branch that's always releasable[1]. We're still on Nix 2.18 in nixpkgs due to too many notable regressions. Enabling people to test latest master may help on that end. * This uses the most bleeding-edge Nix, but our packaging, so we can identify issues with our packaging early. * From what I've seen, most people are using the packages from nixpkgs anyways instead of the upstream flake, this is far more convenient anyways. My plan is to update this once a week. Right now we rely on the `installCheckPhase` here, but as soon as we have proper regression testing[2], we may want to add `nixUnstable` there as well (however with failures being allowed probably). [1] https://discourse.nixos.org/t/nix-release-schedule-and-roadmap/14204 [2] NixOS#304332
2c6cf67
to
49cea07
Compare
Rebased onto latest master, updated Nix to latest master and updated the Perl bindings build for meson support. Btw, somebody double-checking the perl build would be appreciated. |
…78331 Had to rework the nix-perl build a little bit since it's now based on meson. Confirmed that everything from Nix 2.3 works fine with it (confirmed that the `isValidPath` operation is behaving correctly from Perl). This doesn't fix cross though, neither for 2.22 nor later: both configuration systems check for a `curl` & `perl` in the builder's $PATH even though both are only in `buildInputs` in upstream's build. OTOH a native Perl is probably needed for `xsubpp`.
Changed the last commit to include a comment explaining why perl-bindings aren't cross-safe. Nothing we can do much about in nixpkgs though. |
Library tests are fine and tested perl-bindings for all nix versions we've packaged. I'd go for it now. |
}; | ||
}; | ||
|
||
latest = self.nix_2_21; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unstable was at nix_2_22.
Description of changes
Things to discuss first:
nixVersions.git
? OTOH unstable Nix is already insufficiently stable for nixpkgs, so I'm not sure if that even makes a different currently 🤷The idea behind that is to enable users and developers of downstream tools such as home-manager to test Nix master for several reasons:
Nix is currently trying to have a
master
branch that's always releasable[1]. We're still on Nix 2.18 in nixpkgs due to too many notable regressions. Enabling people to test latest master may help on that end.This uses the most bleeding-edge Nix, but our packaging, so we can identify issues with our packaging early.
From what I've seen, most people are using the packages from nixpkgs anyways instead of the upstream flake, this is far more convenient anyways.
My plan is to update this once a week. Right now we rely on the
installCheckPhase
here, but as soon as we have proper regression testing[2], we may want to addnixUnstable
there as well (however with failures being allowed probably).[1] https://discourse.nixos.org/t/nix-release-schedule-and-roadmap/14204
[2] #304332
cc @RaitoBezarius @lovesegfault @Artturin
cc @rycee @Enzime (for hm/nix-darwin as downstream projects that might be interested in that).
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.