Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrpc: 3.3.0 -> 3.4.0 #308269

Merged
merged 2 commits into from
May 2, 2024
Merged

arrpc: 3.3.0 -> 3.4.0 #308269

merged 2 commits into from
May 2, 2024

Conversation

ardishko
Copy link
Contributor

@ardishko ardishko commented May 1, 2024 •
edited
Loading

Description of changes

This PR updates the rev, hash and npmDepsHash to update arrpc to 3.4.0 from 3.3.0

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from NotAShelf May 1, 2024 13:17
NotAShelf
NotAShelf approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotAShelf
Copy link
Member

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@NotAShelf merge not permitted (#305350):
pr author is not in restricted authors list, in the list are: r-ryantm

@NotAShelf
Copy link
Member

oh my bad

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels May 1, 2024
@getchoo
Copy link
Member

getchoo commented May 2, 2024

Result of nixpkgs-review pr 308269 run on aarch64-linux 1

1 package built:
  • arrpc

@getchoo getchoo added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 2, 2024
@wegank wegank merged commit 1067307 into NixOS:master May 2, 2024
31 checks passed
@ardishko ardishko deleted the patch-10 branch May 2, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAShelf NotAShelf NotAShelf approved these changes

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ardishko @NotAShelf @getchoo @wegank