SDL2_mixer: adopt and refactor #308362
Merged
SDL2_mixer: adopt and refactor #308362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Result of 5 packages marked as broken and skipped:
1 package blacklisted:
27 packages failed to build:
242 packages built:
all failures seemed to be failing on hydra, but i'd like to run this anew now that my pygame fixes are merged. Diff LGTM, but merge conflict |
- finalAttrs - use fetchFromGitHub (since the url is deactivated) - strictDeps - no nested with
- get rid of rec - use fetchFromGitHub (since the url is deactivated)
|
Result of 5 packages marked as broken and skipped:
1 package blacklisted:
13 packages failed to build:
261 packages built:
errors are either due to requireFile, or exist on hydra one error of interest, from manaplus: but that error already exists on hydra: https://hydra.nixos.org/build/256700787 LGTM |
Sigmanificient
added
the
0.kind: package adoption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Following #307078
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.