nixos/garage: drop replication_mode setting #309643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got broken up into separate `replication_factor` and `consistency_mode` settings with Garage 1.x, and due to the the "none" default kicking in, Garage fails to startup with > : Error: Either the legacy replication_mode or replication_level and consistency_mode can be set, not both. if we actually make the migratiom as documented in the migration guide. Drop this explicit setting, so users can set replication_mode or replication_factor/consistency_mode, depending on the version they're using.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
yu-re-ka
force-pushed
the
garage-replication_mode
branch
from
8e87754 to
0837845
Compare
|
@yu-re-ka thanks for the assertion ❤️ |
pluiedev
suggested changes
May 13, 2024
pluiedev
suggested changes
May 13, 2024
yu-re-ka
force-pushed
the
garage-replication_mode
branch
from
0837845 to
aa64bb2
Compare
teutat3s
reviewed
May 14, 2024
| # because either replication_factor or replication_mode is required. | ||
| # This assertion can be removed in NixOS 24.11, when all users have been warned once. | ||
| { | ||
| assertion = (cfg.settings ? replication_factor || cfg.settings ? replication_mode) || lib.versionOlder cfg.package "1.0.0"; |
There was a problem hiding this comment.
This should be
Suggested change
| assertion = (cfg.settings ? replication_factor || cfg.settings ? replication_mode) || lib.versionOlder cfg.package "1.0.0"; | |
| assertion = (cfg.settings ? replication_factor || cfg.settings ? replication_mode) || lib.versionOlder cfg.package.version "1.0.0"; |
flokli
added a commit
that referenced
this pull request
May 15, 2024
…ng-tests nixos/garage: reapply #309643, add assertion, fix tests
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken up into separate
replication_factorandconsistency_modesettings with Garage 1.x, and due to the the "none" default kicking in, Garage fails to startup withif we actually make the migration as documented in the migration guide.
Drop this explicit setting, so users can set replication_mode or replication_factor/consistency_mode, depending on the version they're using.
With this PR, redeploying with the old key is a no-op (as expected), and I'm able to switch to
replication_factor/consistency_mode.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.