pipewire: fix cross to executable host #310814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffado uses wrapQtAppsHook in nativeBuildInputs, but and wrapQtAppsHook depends on qtsvg, but buildPackages.qt5.qtsvg doesn't build when cross compiling. So even in the canExecute case, we can't do this. Link: NixOS#269756
alyssais
added
the
6.topic: cross-compilation
ofborg
bot
added
10.rebuild-darwin: 0
|
Yeah it should be used instead of direct comparison, because of something weird to do with function pointers. |
wegank
added
the
12.approvals: 1
brianmcgillion
added a commit
to brianmcgillion/ghaf
that referenced
this pull request
May 31, 2024
fixed in the upstream NixOS/nixpkgs#310814 Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
brianmcgillion
added a commit
to brianmcgillion/ghaf
that referenced
this pull request
May 31, 2024
fixed in the upstream NixOS/nixpkgs#310814 Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
brianmcgillion
added a commit
to tiiuae/ghaf
that referenced
this pull request
Jun 3, 2024
fixed in the upstream NixOS/nixpkgs#310814 Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffado uses wrapQtAppsHook in nativeBuildInputs, but and wrapQtAppsHook depends on qtsvg, but buildPackages.qt5.qtsvg doesn't build when cross compiling. So even in the canExecute case, we can't do this.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.