Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.bayespy: add missing dependency, clean up; python312Packages.truncnorm: init at 0.0.2 #311489

Merged
merged 2 commits into from
May 14, 2024

Conversation

TomaSajt
Copy link
Contributor

Description of changes

ZHF: #309482

This package fixes the build of the bayespy package by adding the missing truncnorm dependency, which hasn't been packaged yet.

I used pyproject = true for both packages.
I also opted to use the GitHub sources instead of the PyPi sources.

@jluttine, I added you as a maintainer for truncnorm, because you maintain the bayespy package both upstream and in nixpkgs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 13, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 13, 2024
@ofborg ofborg bot requested a review from jluttine May 13, 2024 22:56
@wegank
Copy link
Member

wegank commented May 14, 2024

Result of nixpkgs-review pr 311489 run on aarch64-darwin 1

8 packages built:
  • python311Packages.bayespy
  • python311Packages.bayespy.dist
  • python311Packages.truncnorm
  • python311Packages.truncnorm.dist
  • python312Packages.bayespy
  • python312Packages.bayespy.dist
  • python312Packages.truncnorm
  • python312Packages.truncnorm.dist

@wegank wegank merged commit 6b5afbf into NixOS:master May 14, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants