Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dive: patch fix scrolling #311901

Merged

Conversation

GuillaumeDesforges
Copy link
Contributor

@GuillaumeDesforges GuillaumeDesforges commented May 15, 2024

Description of changes

Fixes wagoodman/dive#494 until a new release that includes the fix.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GuillaumeDesforges GuillaumeDesforges force-pushed the gdforj@dive/fix-scroll branch 2 times, most recently from 5746b40 to 108a3f3 Compare May 15, 2024 10:29
@GuillaumeDesforges
Copy link
Contributor Author

GuillaumeDesforges commented May 15, 2024

Wait, I messed up some rebase.

@GuillaumeDesforges
Copy link
Contributor Author

GuillaumeDesforges commented May 15, 2024

I've updated the patches that were already applied to follow wagoodman/dive#473, which is the PR people build these days and is rebased on the patches that were already applied in nixpkgs.

@SuperSandro2000 SuperSandro2000 merged commit e122454 into NixOS:master May 19, 2024
32 of 34 checks passed
@GuillaumeDesforges GuillaumeDesforges deleted the gdforj@dive/fix-scroll branch May 19, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Layers are does not scroll
2 participants