Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.requests: 2.31.0 -> 2.32.2 #313599

Closed
wants to merge 1 commit into from
Closed

python312Packages.requests: 2.31.0 -> 2.32.2 #313599

wants to merge 1 commit into from

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 22, 2024 •
edited
Loading

Changelog: https://github.com/psf/requests/blob/v2.32.2/HISTORY.md

Description of changes

GHSA-9wx4-h78v-vm56

Fixes CVE-2024-35195

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@fabaff
Copy link
Member Author

fabaff commented May 22, 2024

@ofborg build python312Packages.requests python311Packages.requests

@LeSuisse
Copy link
Contributor

LeSuisse commented May 22, 2024 •
edited
Loading

Just a heads up on this one, it might break some of the packages depending on it (notably docker-py): psf/requests#6707

@risicle
Copy link
Contributor

risicle commented May 27, 2024

Please address the merge conflict.

@fabaff
Copy link
Member Author

fabaff commented May 29, 2024

@ofborg build python311Packages.requests python312Packages.requests

@vcunat
Copy link
Member

vcunat commented May 30, 2024

Superseded by PR #315293
(though I see pyproject = true missing from there)

FYI, @mweinelt

@vcunat vcunat closed this May 30, 2024
@mweinelt
Copy link
Member

(though I see pyproject = true missing from there)

Requests 2.33.0 will start using hatchling, until then setuptools will keep working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fabaff @LeSuisse @risicle @vcunat @mweinelt @wegank